Skip to content

Fix data marshaling #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2019
Merged

Fix data marshaling #788

merged 2 commits into from
Apr 8, 2019

Conversation

@nxtn
Copy link
Contributor

@nxtn nxtn commented Apr 4, 2019

Contributes to dotnet/docs#11396
Continued from dotnet/docs#11450

It's a common mistake to marshal pointers as int type.

Related to dotnet/csharplang#2324. Is there anyone to review the PRs there?

@nxtn nxtn requested a review from BillWagner as a code owner April 4, 2019 15:53
BillWagner
BillWagner requested changes Apr 5, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes. I agree with your suggestion on the name changes. Once you make that change, I'll :shipit:

I chose "request changes" so it stays in my queue to review (and approve and merge).

@nxtn nxtn mentioned this pull request Apr 5, 2019
Merged
@BillWagner BillWagner merged commit 6d8b7ae into dotnet:master Apr 8, 2019
@nxtn nxtn deleted the msgbox branch April 8, 2019 14:27
@dotnet dotnet deleted a comment from BillWagner Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nxtn @BillWagner