-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fold ranges changes into initial spec #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See dotnet/docs#12772 (comment) This will read better as a coherent story for the Range and Index features as delivered.
604250f to
dd4e903
Compare
proposals/csharp-8.0/ranges.md
Outdated
| Moreover, `System.Index` should have an implicit conversion from `System.Int32`, in order not to need to overload for mixing integers and indexes over multi-dimensional signatures. | ||
|
|
||
| ## Workarounds | ||
| ## Adding Index and Range support to library types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would clean this up a bit by changing the language from proposal to spec. There's a lot of discussion about the design problems with the previous system which is not really relevant when the new spec is incorporated. In other words, I don't think the historical account is useful for the full spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I was chatting about this with @MadsTorgersen today. I do like the idea of making these more like formal specs as they move to completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this instance, I made a smaller set of changes to simplify the reading here.
As another PR, I'd like to rework this (and other proposals) to use more spec like language. Your comment above could be said for many of the proposals. In all cases, I'd like to stage the changes in two phases:
- Get the technical details correct.
- Update the language from spec to proposal.
We should discuss which order is better in general, but since this is in progress, I'd like to start with combining these two documents, and then address the language throughout the document in a separate PR.
This removes some of the history and concerns with the previous design.
See dotnet/docs#12772 (comment)
This will read better as a coherent story for the Range and Index features as delivered.
Notes on changes:
None of the semantics of the proposal was changed.
One question for reviewers: Should I change the verb tense from future to present tense on this proposal?
Supports dotnet/docs#14344