Skip to content

Conversation

@BillWagner
Copy link
Member

See dotnet/docs#12772 (comment)

This will read better as a coherent story for the Range and Index features as delivered.

Notes on changes:

  1. index-range-changes is deleted.
  2. content from index-range-changes.md was moved into ranges.md
  3. Fix markdown lint issues.

None of the semantics of the proposal was changed.

One question for reviewers: Should I change the verb tense from future to present tense on this proposal?

Supports dotnet/docs#14344

@BillWagner BillWagner requested review from agocke and jcouv September 10, 2019 19:42
@BillWagner BillWagner force-pushed the update-proposal-links branch from 604250f to dd4e903 Compare September 22, 2019 13:05
Moreover, `System.Index` should have an implicit conversion from `System.Int32`, in order not to need to overload for mixing integers and indexes over multi-dimensional signatures.

## Workarounds
## Adding Index and Range support to library types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clean this up a bit by changing the language from proposal to spec. There's a lot of discussion about the design problems with the previous system which is not really relevant when the new spec is incorporated. In other words, I don't think the historical account is useful for the full spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I was chatting about this with @MadsTorgersen today. I do like the idea of making these more like formal specs as they move to completion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance, I made a smaller set of changes to simplify the reading here.

As another PR, I'd like to rework this (and other proposals) to use more spec like language. Your comment above could be said for many of the proposals. In all cases, I'd like to stage the changes in two phases:

  1. Get the technical details correct.
  2. Update the language from spec to proposal.

We should discuss which order is better in general, but since this is in progress, I'd like to start with combining these two documents, and then address the language throughout the document in a separate PR.

This removes some of the history and concerns with the previous design.
@BillWagner BillWagner merged commit 65ea1e6 into dotnet:master Sep 27, 2019
@BillWagner BillWagner deleted the update-proposal-links branch September 27, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants