Publish the remaining specifications for C# 8 #14344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#12772 There are three small changes in this PR: 1. add TOC nodes for the remaining C# 8 features. 1. Remove "preview" language from the language reference home page. 1. Change "language proposals" to "specification proposal". Include clarifying language in the home page. The hypothesis is that it removes confusion because these are proposals that will be refined for the standard, not proposals that haven't been implemented.
pkulikov
reviewed
Sep 10, 2019
Co-Authored-By: Petr Kulikov <petr.kulikov@gmail.com>
mairaw
approved these changes
Sep 11, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
LGTM. Left a couple of comments for you to consider.
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
It turns out that relying on the redirects does not build cleanly.
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Sep 11, 2019
See dotnet#14344 I missed updating the ms-date metadata for the C# 8.0 specifications in that PR. This PR addresses that omission.
Merged
BillWagner
added a commit
that referenced
this pull request
Sep 11, 2019
See #14344 I missed updating the ms-date metadata for the C# 8.0 specifications in that PR. This PR addresses that omission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12772
There are three small changes in this PR: