Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our tools should format messages to match GitHub's UI format #1125

Open
BillWagner opened this issue Jun 3, 2024 · 2 comments
Open

Our tools should format messages to match GitHub's UI format #1125

BillWagner opened this issue Jun 3, 2024 · 2 comments

Comments

@BillWagner
Copy link
Member

We should format the error output for the TOC / anchor generator, Word generator, and the test extractor so that they participate in the GitHub PR Review process as markdownlint lint does.

@jskeet I'll take this on in a combination of 3 PRs if you want.
@jskeet
Copy link
Contributor

jskeet commented Jun 3, 2024

Sounds good to me, thanks :)

This was referenced Jun 24, 2024
Merged
Merged
BillWagner added a commit to BillWagner/csharpstandard that referenced this issue Sep 19, 2024
@BillWagner
Add status checks to the test runner
d6bf6dc 
Contributes to dotnet#1125

Replace the existing logging code with the utility class that writes to the console, and adds a status check record.

Log failures as status checks, but status is only to the output console.
@BillWagner BillWagner mentioned this issue Sep 19, 2024
Open
@BillWagner
Copy link
Member Author

The only tool remaining to hook into this mechanism is the grammar validator. That might be able to do it using curl, but let's wait a bit until the next updates are in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jskeet @BillWagner