Add status checks to the test runner #1179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to dotnet#1125 Replace the existing logging code with the utility class that writes to the console, and adds a status check record. Log failures as status checks, but status is only to the output console.
BillWagner
commented
Sep 19, 2024
| @@ -10,7 +10,7 @@ namespace Utilities; | |||
| /// <param name="Id">The error message ID</param> | |||
| /// <param name="StartLine">The start line (index from 1)</param> | |||
| /// <param name="EndLine">The end line (index from 1)</param> | |||
| public record Diagnostic(string file, int StartLine, int EndLine, string Message, string Id); | |||
| public record StatusCheckMessage(string file, int StartLine, int EndLine, string Message, string Id); | |||
There was a problem hiding this comment.
I changed the name of this record type because the tester uses the "Diagnostic" class from the roslyn APIs. We don't use this in too many places, so the global change seemed the right way to go
tools/Utilities/StatusCheckLogger.cs
Outdated
| /// Log the diagnostic information to console. These will only appear in the console window, not | ||
| /// as annotations on the changes in the PR. | ||
| /// </remarks> | ||
| public void ConsoleOnlyLog(StatusCheckMessage d) |
There was a problem hiding this comment.
I added this method because it looks like many of the status messages on the tester would be just to the console, rather than annotate the spec with info on every test.
BillWagner
commented
Sep 19, 2024
|
Will review on Tuesday when I'm back at work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1125
Replace the existing logging code with the utility class that writes to the console, and adds a status check record.
Log failures as status checks, but status is only to the output console.