Skip to content

Conversation

@BillWagner
Copy link
Member

Fixes #7884

The List<T> example causes confusion with the .NET Standard type System.Collections.Generic.List<T>

Change the name of that type, update all references to the type name, and add a note to the .NET Standard type.

Depends on dotnet/samples#785

We prefer ~ - based links to samples, because those links are from another repository.
Fixes dotnet#7884

The `List<T>` example causes confusion with the .NET Standard type `System.Collections.Generic.List<T>`

Change the name of that type, update all references to the type name, and add a note to the .NET Standard type.

Depends on dotnet/samples#785
@BillWagner BillWagner requested a review from Thraka April 3, 2019 20:23
@BillWagner
Copy link
Member Author

closing and re-opening for a new build.

@BillWagner BillWagner closed this Apr 3, 2019
@BillWagner BillWagner reopened this Apr 3, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments for you to consider

mairaw and others added 3 commits April 3, 2019 19:03
@BillWagner BillWagner merged commit fb3465b into dotnet:master Apr 3, 2019
@BillWagner BillWagner deleted the change-generic-example branch April 3, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants