Change List to MyList #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sample code creates a list object, which is easily read as discussing the System.Collections.Generic.List class. Contributes to dotnet/docs#7884
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Apr 3, 2019
Fixes dotnet#7884 The `List<T>` example causes confusion with the .NET Standard type `System.Collections.Generic.List<T>` Change the name of that type, update all references to the type name, and add a note to the .NET Standard type. Depends on dotnet/samples#785
rpetrusha
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
LGTM, @BillWagner. You can merge when you're ready, and probably should rebuild dotnet/docs#11649.
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Apr 3, 2019
* change relative links We prefer ~ - based links to samples, because those links are from another repository. * Replace List with MyList Fixes #7884 The `List<T>` example causes confusion with the .NET Standard type `System.Collections.Generic.List<T>` Change the name of that type, update all references to the type name, and add a note to the .NET Standard type. Depends on dotnet/samples#785 * Apply suggestions from code review Co-Authored-By: BillWagner <wiwagn@microsoft.com> * fix reference link. * fix typo in link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sample code creates a list object, which is easily read as discussing the System.Collections.Generic.List class.
Contributes to dotnet/docs#7884