Skip to content

Conversation

@JRAlexander
Copy link
Contributor

@JRAlexander JRAlexander commented May 1, 2019

@JRAlexander JRAlexander added this to the May 2019 milestone May 1, 2019
@JRAlexander JRAlexander self-assigned this May 1, 2019
@JRAlexander JRAlexander changed the title Add SalesAnomalyDetection tutorial Add ProductSalesAnomalyDetection tutorial May 1, 2019
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Minor changes


Add the following call to the `DetectChangepoint()`method as the next line of code in the `Main()` method:

[!code-csharp[CallDetectChangepoint](~/samples/machine-learning/tutorials/ProductSalesAnomalyDetection/Program.cs#CallDetectChangepoint]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this code snippet. Might be broken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Missing an ending parenthesis. Good catch!

@JRAlexander
Copy link
Contributor Author

Closing and reopening

@JRAlexander JRAlexander closed this May 1, 2019
@JRAlexander JRAlexander reopened this May 1, 2019
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JRAlexander JRAlexander merged commit 465c873 into dotnet:staging May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants