Skip to content

Conversation

@JRAlexander
Copy link
Contributor

@JRAlexander JRAlexander commented Apr 18, 2019

Add ProductSalesAnomalyDetection code sample for tutorial.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @JRAlexander. Minor suggestions.

// <SnippetDeclareGlobalVariables>
static readonly string _dataPath = Path.Combine(Environment.CurrentDirectory, "Data", "sales-of-shampoo-over-a-three-ye.csv");
//assign the Number of records in dataset file to constant variable
const int _docsize = 36;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Compute the value to allow for changes in the data source.

long size = dataView.GetRowCount().HasValue ? dataView.GetRowCount().Value : 0;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks, @luisquintanilla!

@JRAlexander JRAlexander added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Apr 25, 2019
@JRAlexander JRAlexander changed the title Add ShampooSalesAnomalyDetection Add ProductSalesAnomalyDetection May 1, 2019
@JRAlexander JRAlexander changed the base branch from master to staging May 1, 2019 19:32
@JRAlexander JRAlexander merged commit e5aa43d into dotnet:staging May 1, 2019
@JRAlexander JRAlexander removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants