Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NullableContextOptions to Nullable #12497

Merged
merged 1 commit into from
May 23, 2019
Merged

Rename NullableContextOptions to Nullable #12497

merged 1 commit into from
May 23, 2019

Conversation

KexyBiscuit
Copy link
Contributor

Summary

Rename NullableContextOptions to Nullable.

See also dotnet/roslyn#35901.

@KexyBiscuit KexyBiscuit requested a review from BillWagner as a code owner May 23, 2019 03:10
@dnfclas
Copy link

dnfclas commented May 23, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@drewnoakes drewnoakes mentioned this pull request May 23, 2019
Closed
@BillWagner
Copy link
Member

See #12417

This PR addresses the changes in the C# Guide.

BillWagner
BillWagner approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @KexyBiscuit I'm grateful.

I've read through the changes and I'll :shipit: now.

Thanks again for helping to keep our docs up to date! 🎆

@BillWagner BillWagner merged commit e3a246c into dotnet:master May 23, 2019
@BillWagner BillWagner mentioned this pull request May 23, 2019
Closed
@rainersigwald
Copy link
Member

This is the correct change moving forward, but I have a concern: the Nullable rename has not yet shipped in a .NET Core SDK preview. 3.0.100-preview5-011568 still uses the name NullableContextOptions, so dotnet CLI users might use these new instructions and then see confusing errors (the inverse of the confusing errors that VS 16.2-p1 users see with the old name).

@BillWagner
Copy link
Member

@rainersigwald

Good point. I'll add more clarifying language in a new PR.

@BillWagner BillWagner mentioned this pull request May 23, 2019
Merged
@filipw filipw mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KexyBiscuit @dnfclas @BillWagner @rainersigwald @drewnoakes