Add a note about the point-in-time concern with VS and the CLI #12503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .NET SDK CLI does not yet include the rename from NullableContextOptions to Nullable.
rainersigwald
approved these changes
May 23, 2019
There was a problem hiding this comment.
LGTM but I've been talking offline with @jaredpar about this so he should weigh in.
rpetrusha
approved these changes
May 23, 2019
There was a problem hiding this comment.
LGTM, @BillWagner. Left one comment for you to consider that applies to all three of your changes. You can merge when you're ready.
Change from NOTE to IMPORTANT
Thraka
suggested changes
May 23, 2019
Thraka
approved these changes
May 23, 2019
drewnoakes
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET SDK CLI does not yet include the rename from NullableContextOptions to Nullable.
See #12497 (comment)
/cc @rainersigwald