-
Notifications
You must be signed in to change notification settings - Fork 6k
New doc for console log formatter APIs #21182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@maryamariyan this looks fantastic @IEvangelist would it be possible for you to:
@maryamariyan has done all the hard work, it just needs some editorial polish. |
I'll take it from here, thanks! |
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Youssef1313
reviewed
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@shirhatti @Rick-Anderson
As the first draft could you please help me check:
Next please let me know if I need to use other ways to share source code, perhaps:
Then we can go through the proper wording and I will fixup the wordings once the big issues are addressed.
Fixes dotnet/AspNetCore.Docs#19224
PS edit by
@Rick-AndersonInternal review URL