Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding console log formatting article #21189

Merged
merged 11 commits into from
Oct 27, 2020
Merged

Adding console log formatting article #21189

merged 11 commits into from
Oct 27, 2020

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Oct 22, 2020 •
edited
Loading

Summary

Take @maryamariyan's fork/branch, updating:

  • Migrate code in snippets
  • Add this to the TOC
  • Editorial polish

Closes #21182

Preview

✔️ Console log formatting

@IEvangelist IEvangelist requested a review from a team as a code owner October 22, 2020 15:53
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 22, 2020
@IEvangelist IEvangelist self-assigned this Oct 22, 2020
@IEvangelist
Apply suggestions from code review
9858edc 
Fix occurrences of proceeding 🤦
BillWagner
BillWagner approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @IEvangelist

You can :shipit: when ready.

@IEvangelist IEvangelist merged commit b118794 into dotnet:master Oct 27, 2020
@IEvangelist IEvangelist deleted the console-log branch October 27, 2020 14:51
@shirhatti shirhatti mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@tdykstra tdykstra Awaiting requested review from tdykstra

Assignees

@IEvangelist IEvangelist

Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@IEvangelist @BillWagner @dotnet-bot @maryamariyan