Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit pass for LINQ "get started" section. #38723

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 12, 2023

This PR moves the content for the section on "Get Started with LINQ" to match the TOC. It will be easiest to review commit-by-commit:

  1. Fix existing issues with content that moves.
  2. Move all moving content (articles, images, included snippets).
  3. Refactor sample code and tests.
  4. Edit article text.
  5. Use clean-repo to fix links
  6. Use clean-repo to replace absolute links with relative links
  7. Remove redundant links.

As part of the major edits:

Fixes #28606
Fixes #36501

This table shows the change and preview before the final commits updating links. These contains contain the major changes:


Internal previews

📄 File 🔗 Preview link
docs/csharp/linq/get-started/features-that-support-linq.md C# Features That Support LINQ
docs/csharp/linq/get-started/introduction-to-linq-queries.md Introduction to LINQ Queries (C#)
docs/csharp/linq/get-started/query-expression-basics.md Query expression basics (LINQ in C#)
docs/csharp/linq/get-started/type-relationships-in-linq-query-operations.md Type Relationships in LINQ Query Operations (C#)
docs/csharp/linq/get-started/write-linq-queries.md docs/csharp/linq/get-started/write-linq-queries
docs/csharp/linq/index.md Language Integrated Query (LINQ)

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/csharp/language-reference/compiler-messages/cs1941.md Compiler Error CS1941
docs/csharp/language-reference/compiler-messages/ref-modifiers-errors.md Errors and warnings associated with reference parameters, variables, and returns
docs/csharp/language-reference/keywords/from-clause.md "from clause - C# Reference"
docs/csharp/language-reference/keywords/select-clause.md select clause (C# Reference)
docs/csharp/linq/get-started/features-that-support-linq.md docs/csharp/linq/get-started/features-that-support-linq
docs/csharp/linq/get-started/introduction-to-linq-queries.md Introduction to LINQ Queries (C#)
docs/csharp/linq/get-started/query-expression-basics.md Query expression basics (LINQ in C#)
docs/csharp/linq/get-started/type-relationships-in-linq-query-operations.md Type Relationships in LINQ Query Operations (C#)
docs/csharp/linq/get-started/write-linq-queries.md docs/csharp/linq/get-started/write-linq-queries
docs/csharp/linq/handle-exceptions-in-query-expressions.md Handle exceptions in query expressions
docs/csharp/linq/index.md Language Integrated Query (LINQ) in C#
docs/csharp/misc/cs1949.md Compiler Error CS1949
docs/csharp/programming-guide/concepts/linq/how-to-query-an-arraylist-with-linq.md How to query an ArrayList with LINQ (C#)
docs/csharp/programming-guide/concepts/linq/walkthrough-writing-queries-linq.md Walkthrough: Writing Queries in C# (LINQ)
docs/csharp/tutorials/working-with-linq.md docs/csharp/tutorials/working-with-linq
docs/csharp/whats-new/csharp-version-history.md The history of C#
docs/framework/data/adonet/ef/language-reference/queries-in-linq-to-entities.md Queries in LINQ to Entities
docs/framework/data/adonet/queries-in-linq-to-dataset.md "Queries in LINQ to DataSet"
docs/framework/data/adonet/sql/linq/aggregate-queries.md Aggregate Queries
docs/framework/data/adonet/sql/linq/how-to-call-user-defined-functions-inline.md How to: Call User-Defined Functions Inline
docs/framework/data/adonet/sql/linq/how-to-query-for-information.md "How to: Query for Information"
docs/framework/data/adonet/sql/linq/linq-to-sql-queries.md LINQ to SQL Queries
docs/framework/data/adonet/sql/linq/query-concepts.md docs/framework/data/adonet/sql/linq/query-concepts
docs/framework/data/adonet/sql/linq/walkthrough-simple-object-model-and-query-csharp.md Walkthrough: Simple Object Model and Query (C#)
docs/framework/data/adonet/sql/linq/walkthrough-simple-object-model-and-query-visual-basic.md "Walkthrough: Simple Object Model and Query (Visual Basic)"
docs/fundamentals/apicompat/assembly-validation.md Assembly validation
docs/standard/collections/index.md Collections and Data Structures
docs/standard/linq/concepts-terminology-functional-transformation.md docs/standard/linq/concepts-terminology-functional-transformation
docs/standard/linq/generate-text-files-xml.md How to generate text files from XML (LINQ to XML)
docs/standard/linq/query-xml-trees-overview.md Query XML trees overview - LINQ to XML

Fixes dotnet#28863 - Add a note to include a using for `System.Linq`, unless you're project includes implicit usings. Add links to both.

Fixes dotnet#36684 - The text in the article used the phrase "between 3 and 7", but the sample was less than 3 or greater than 7. Fix the code to match the text.
@dotnet-bot dotnet-bot added this to the December 2023 milestone Dec 12, 2023
@ghost ghost added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Dec 12, 2023
@BillWagner BillWagner force-pushed the update-linq-get-started branch from a97bb3c to 7aefbba Compare December 13, 2023 16:02
Move all MD files, associated snippets, and associated media for the "get started with LINQ" section into that section.

Move test project to new location.

Delete orphaned snippet projects.
@BillWagner BillWagner force-pushed the update-linq-get-started branch from 703a64f to fbe8e21 Compare December 13, 2023 18:36
Make sure all snippets are called in the main program. Remove any unused code in the snippets for this folder.
@BillWagner BillWagner force-pushed the update-linq-get-started branch from e57591b to da1a57c Compare December 14, 2023 21:52
@BillWagner BillWagner marked this pull request as ready for review December 14, 2023 22:02
@BillWagner BillWagner requested review from IEvangelist, a team and mcleblanc as code owners December 14, 2023 22:02
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just noted a few nits.

docs/csharp/linq/get-started/features-that-support-linq.md Outdated Show resolved Hide resolved
docs/csharp/linq/index.md Outdated Show resolved Hide resolved
docs/csharp/linq/index.md Outdated Show resolved Hide resolved
BillWagner and others added 2 commits December 15, 2023 08:54
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@BillWagner BillWagner enabled auto-merge (squash) December 15, 2023 14:14
@BillWagner BillWagner merged commit d61b2d0 into dotnet:main Dec 15, 2023
8 checks passed
@BillWagner BillWagner deleted the update-linq-get-started branch December 15, 2023 14:31
BillWagner added a commit that referenced this pull request Dec 15, 2023
* Clarify L2 identifier names (#38761)

* Clarify L2 identifier names

Add an important note regarding L2 identifier names and the official GB18020-2022 standard.

* typo

* Update package index with latest published versions (#38772)

* Wrap M1 and M2 methods in C class to avoid errors (#38773)

* Tag the F# team for review and ownership (#38770)

* Tag the F# team for review and ownership

The F# docs had metadata that still pointed to the former language PM. Replace that with the F# compiler team and current PM.

While making those changes, update the CODEOWNERS file for the same reason.

* replace Brice with Arthur

Arthur Vickers is now responsible for SQL Lite docs.

* one typo

* Update docfx.json

* one typo

* build warnings

* Update package index with latest published versions (#38776)

* Reflect in the documentation that the LOHThreshold has to be less than region_size

* Expand on source link breaking change (#38777)

* Update package index with latest published versions (#38780)

* Upgrade TFMs to .NET 8.0, and packages (#38752)

* Upgrade TFMs to .NET 8.0, and packages

* Remove worker versioning

* Fix ranges, etc.

* Edit pass for LINQ "get started" section. (#38723)

* Fix Open issues

Fixes #28863 - Add a note to include a using for `System.Linq`, unless you're project includes implicit usings. Add links to both.

Fixes #36684 - The text in the article used the phrase "between 3 and 7", but the sample was less than 3 or greater than 7. Fix the code to match the text.

* move files

Move all MD files, associated snippets, and associated media for the "get started with LINQ" section into that section.

Move test project to new location.

Delete orphaned snippet projects.

* refactor sample source

Make sure all snippets are called in the main program. Remove any unused code in the snippets for this folder.

* proofread and edit.

* replace redirects.

* replace absolute links with relative links

* remove redundant links

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* respond to feedback

---------

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* Add mstest runner docs (#38459)

* Add mstest runner docs

* Add mstest runner docs

* no trailing spaces

* Fix links

* Use proper callouts

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* More suggestions

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

* Refactoring

* Fix linting issue

* Fix headings in error codes

* Fix headings in error codes

* Apply suggestions from code review

Co-authored-by: Jakub Jareš <me@jakubjares.com>

* Add comparison of vstest and mstest runner

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/core/testing/unit-testing-mstest-runner-vs-vstest.md

* Update docs/core/testing/unit-testing-mstest-runner-vs-vstest.md

---------

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com>
Co-authored-by: Andrew Au <cshung@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Jakub Jareš <me@jakubjares.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csharp-linq/subsvc dotnet-csharp/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
3 participants