Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify L2 identifier names #38761

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 13, 2023

Add an important note regarding L2 identifier names and the official GB18020-2022 standard.


Internal previews

📄 File 🔗 Preview link
docs/csharp/fundamentals/coding-style/identifier-names.md C# identifier naming rules and conventions

Add an important note regarding L2 identifier names and the official GB18020-2022 standard.
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@BillWagner BillWagner merged commit 9a45845 into dotnet:main Dec 14, 2023
8 checks passed
@BillWagner BillWagner deleted the clarify-L2-characters branch December 14, 2023 14:19
BillWagner added a commit that referenced this pull request Dec 15, 2023
* Clarify L2 identifier names (#38761)

* Clarify L2 identifier names

Add an important note regarding L2 identifier names and the official GB18020-2022 standard.

* typo

* Update package index with latest published versions (#38772)

* Wrap M1 and M2 methods in C class to avoid errors (#38773)

* Tag the F# team for review and ownership (#38770)

* Tag the F# team for review and ownership

The F# docs had metadata that still pointed to the former language PM. Replace that with the F# compiler team and current PM.

While making those changes, update the CODEOWNERS file for the same reason.

* replace Brice with Arthur

Arthur Vickers is now responsible for SQL Lite docs.

* one typo

* Update docfx.json

* one typo

* build warnings

* Update package index with latest published versions (#38776)

* Reflect in the documentation that the LOHThreshold has to be less than region_size

* Expand on source link breaking change (#38777)

* Update package index with latest published versions (#38780)

* Upgrade TFMs to .NET 8.0, and packages (#38752)

* Upgrade TFMs to .NET 8.0, and packages

* Remove worker versioning

* Fix ranges, etc.

* Edit pass for LINQ "get started" section. (#38723)

* Fix Open issues

Fixes #28863 - Add a note to include a using for `System.Linq`, unless you're project includes implicit usings. Add links to both.

Fixes #36684 - The text in the article used the phrase "between 3 and 7", but the sample was less than 3 or greater than 7. Fix the code to match the text.

* move files

Move all MD files, associated snippets, and associated media for the "get started with LINQ" section into that section.

Move test project to new location.

Delete orphaned snippet projects.

* refactor sample source

Make sure all snippets are called in the main program. Remove any unused code in the snippets for this folder.

* proofread and edit.

* replace redirects.

* replace absolute links with relative links

* remove redundant links

* Apply suggestions from code review

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* respond to feedback

---------

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>

* Add mstest runner docs (#38459)

* Add mstest runner docs

* Add mstest runner docs

* no trailing spaces

* Fix links

* Use proper callouts

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* More suggestions

* Update docs/core/testing/unit-testing-mstest-runner-intro.md

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

* Refactoring

* Fix linting issue

* Fix headings in error codes

* Fix headings in error codes

* Apply suggestions from code review

Co-authored-by: Jakub Jareš <me@jakubjares.com>

* Add comparison of vstest and mstest runner

* Apply suggestions from code review

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

* Update docs/core/testing/unit-testing-mstest-runner-vs-vstest.md

* Update docs/core/testing/unit-testing-mstest-runner-vs-vstest.md

---------

Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Bartosz Klonowski <70535775+BartoszKlonowski@users.noreply.github.com>
Co-authored-by: Andrew Au <cshung@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Jakub Jareš <me@jakubjares.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants