Skip to content

Conversation

@rpetrusha
Copy link
Contributor

Modified title and example code in consuming a class library tutorial

Fixes #4139

Depends on code in PR dotnet/samples#103

@rpetrusha rpetrusha added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jun 5, 2018
@rpetrusha rpetrusha requested a review from mairaw as a code owner June 5, 2018 21:39
@rpetrusha rpetrusha requested a review from BillWagner as a code owner June 6, 2018 18:29
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great changes @rpetrusha

You can :shipit: when you've merged the samples PR and everything builds.

@rpetrusha
Copy link
Contributor Author

Closing and opening to start a new build now that the new source is merged.

@rpetrusha rpetrusha closed this Jun 6, 2018
@rpetrusha rpetrusha reopened this Jun 6, 2018
@rpetrusha rpetrusha merged commit dc1b19a into dotnet:master Jun 6, 2018
@rpetrusha rpetrusha deleted the library branch June 6, 2018 20:49
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consuming a class library with .NET Core in Visual Studio 2017

3 participants