Skip to content

Revised code for consuming a class library #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2018
Merged

Revised code for consuming a class library #103

merged 1 commit into from
Jun 6, 2018

Conversation

@rpetrusha
Copy link

@rpetrusha rpetrusha commented Jun 5, 2018

Revised code for consuming a class library

This code corrects two issues in the original example:

  • The Console.WindowHeight method is not implemented on non-Windows systems.
  • The console was cleared without displaying the result of the last method call.

@rpetrusha rpetrusha requested a review from BillWagner as a code owner June 5, 2018 21:32
@rpetrusha rpetrusha mentioned this pull request Jun 5, 2018
Merged
BillWagner
BillWagner approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can ship it when ready.

@rpetrusha rpetrusha merged commit 24af3ab into dotnet:master Jun 6, 2018
@rpetrusha rpetrusha deleted the library branch June 6, 2018 20:01
karelz pushed a commit to karelz/samples that referenced this pull request Aug 31, 2018
@karelz
Revised code for consuming a class library (dotnet#103)
8e9a780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpetrusha @BillWagner