Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jun 30, 2018

No description provided.

v-maudel and others added 5 commits June 29, 2018 09:00
Hello, @Xansky ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
"This is an instance of source issue since links for products that have migrated to markdig should be written in the []() form. Nonetheless, this link reported as missing in the targets does not redirect to any URL, thus it should be escaped"

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.

Many thanks in advance.
* C26917: Misuse of ´ to create codeboxes at line 179

Hello, @mairaw,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
"this bug is affected by a source issue by the ´ used to create codeboxes"  

Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.

Many thanks in advance.

* Updated as suggested
@mairaw mairaw requested a review from BillWagner as a code owner June 30, 2018 17:15
* Categories in "Accessibility" are incorrect

-The brief provided for "private protected" should be the brief for "protected internal" instead. 
-As per my knowledge in c#, "private protected" access modifier does not exist. If it does what does this exactly do?

* Update classes-and-objects.md

-Updated brief for protected internal as per the review comment
-Added private protected back with some modification as per the reference doc.

* Update classes-and-objects.md

Added back the private protected with its original brief.

* Updated the number of categories of accessiblility

Updated the number of categories of accessiblility from five to six.

* quick grammar fix
@mairaw mairaw removed the request for review from BillWagner June 30, 2018 20:50
@mairaw mairaw merged commit 736ec4d into live Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants