Skip to content

Make "What's new in C# 6" interactive #9551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jan 7, 2019
Merged

Make "What's new in C# 6" interactive #9551

merged 47 commits into from
Jan 7, 2019

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 11, 2018 •
edited
Loading

Contributes to #8206
Fixes #5169

This depends on dotnet/samples#550

This PR makes three distinct changes to the what's new content:

  1. The article for "What's new in C# 6" is more concise, providing only an overview of each feature.
  2. A new interactive "Explore C# 6" is added. This enables readers to explore the features.
  3. Update the description of initializer improvements for Index Initializers section is inaccurate #5169

There will be extensive links between the overview and the interactive tutorial.

Internal review site links:
What's new in C# 6
Explore C# 6
Object and Collection initializers
How to: Initialize objects using object initializers
How to: Initialize a dictionary using object initializers

@BillWagner
Step 1: Trim "What's New" article
f33be5b 
The "what's new" article has fewer examples, and provides an overview of the feature.
@BillWagner
Add the YAML tutorial
cfc2330
@BillWagner
fix a YAML issue
2b3f114
@BillWagner
Copy link
Member Author

BillWagner commented Dec 14, 2018 •
edited
Loading

Still to finish on this PR:

  • Validate snippet build
  • Cross-link from what's new to explore
  • Move sample code to samples repo (new PR)

pkulikov
pkulikov reviewed Dec 16, 2018
View reviewed changes
@BillWagner
update interactive samples
9e3cf90 
How tos are done.
Links for new exploration tutorials are done.
@BillWagner BillWagner added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Dec 20, 2018
@BillWagner BillWagner changed the title [WIP] Make "What's new in C# 6" interactive Make "What's new in C# 6" interactive Dec 20, 2018
@BillWagner BillWagner mentioned this pull request Dec 20, 2018
Merged
Thraka
Thraka reviewed Dec 21, 2018
View reviewed changes
mairaw
mairaw reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks so cool @BillWagner!
It will be easier to review this once the samples are in but thought I'd leave some quick comments on things that I noticed.

mairaw and others added 9 commits December 24, 2018 12:00
@mairaw @BillWagner
Update docs/csharp/programming-guide/classes-and-structs/object-and-c…
ad26a51 
…ollection-initializers.md

Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/programming-guide/classes-and-structs/object-and-c…
2b60a04 
…ollection-initializers.md

Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/exploration/csharp-6.yml
df08383 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/exploration/csharp-6.yml
367e630 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/exploration/csharp-6.yml
ca5169c 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/exploration/csharp-6.yml
da7d9c2 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/index.md
d54055b 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@mairaw @BillWagner
Update docs/csharp/tutorials/exploration/csharp-6.yml
7390df8 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
respond to feedback
7c5b144
@BillWagner BillWagner mentioned this pull request Dec 27, 2018
Merged
@BillWagner BillWagner removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Dec 27, 2018
Thraka
Thraka suggested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some broken/missing examples.

Ron Petrusha and others added 15 commits January 4, 2019 17:20
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
71eed05 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
893fb9a 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
2d4171e 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
42903ad 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
8eee6ef 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
0a8058d 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
55986d4 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
a2378d6 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
3f82608 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
426d574 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
Update docs/csharp/whats-new/csharp-6.md
1e9a279 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
respond to feedback.
43ff86f
@BillWagner
merge feedback
96d46e2
@pkulikov @BillWagner
Update docs/csharp/whats-new/csharp-6.md
953a212 
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
@BillWagner
respond to feedback.
0e78c9b
@BillWagner BillWagner mentioned this pull request Jan 4, 2019
Merged
@BillWagner BillWagner added changes-addressed 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) and removed 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels Jan 4, 2019
@BillWagner
Copy link
Member Author

BillWagner commented Jan 4, 2019

closing and re-opening for a new build.

@BillWagner BillWagner closed this Jan 4, 2019
@BillWagner BillWagner reopened this Jan 4, 2019
@BillWagner
Copy link
Member Author

BillWagner commented Jan 7, 2019

closing and reopening to force a new OPS build.

@BillWagner BillWagner closed this Jan 7, 2019
@BillWagner BillWagner reopened this Jan 7, 2019
@BillWagner BillWagner merged commit 946c375 into dotnet:master Jan 7, 2019
@BillWagner BillWagner deleted the interactive-csharp6-take2 branch January 7, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw left review comments

+3 more reviewers

@rpetrusha rpetrusha rpetrusha approved these changes

@pkulikov pkulikov pkulikov left review comments

@Thraka Thraka Thraka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BillWagner @Thraka @rpetrusha @mairaw @pkulikov