Skip to content

Conversation

@BillWagner
Copy link
Member

This PR removes samples that are no longer used after dotnet/docs#9551 is merged.

This PR must wait until that PR is merged.

@BillWagner BillWagner added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Dec 20, 2018
@BillWagner BillWagner requested a review from Thraka December 20, 2018 20:58
Copy link
Contributor

@Thraka Thraka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me if you checked that these deleted snippets weren't referenced elsewhere 😁

@mairaw
Copy link
Contributor

mairaw commented Dec 21, 2018

Builds will start to warn us about that if they are 😄

@Thraka
Copy link
Contributor

Thraka commented Dec 21, 2018

Oh good :)

@BillWagner BillWagner merged commit 382928b into dotnet:master Jan 8, 2019
@BillWagner BillWagner deleted the remove-outdated-samples branch January 8, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants