-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify when DbDataReader.GetSchemaTable returns null #4711
Conversation
Docs Build status updates of commit ebb298f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roji Left a suggestion for you to consider.
@TianqiZhang @joelmartinez do you know why the build passed for this change, considering the new text was outside xml elements? |
@carlossanlop The pipeline (for the most part) really only processes the elements that it is familiar with ... so in case like this where it encounters free-floating text, it just skips over it since it doesn't know what to do with it. |
@roji can you please take a look again at this PR? I left some suggestions. There are also branch conflicts to resolve. |
Docs Build status updates of commit 320fc02: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
@carlossanlop sorry for leaving this PR for so long. I've merged the suggested fix and rebased on the latest master, resolving conflicts. |
Docs Build status updates of commit 6ac08fe:
|
File | Status | Preview URL | Details |
---|---|---|---|
xml/System.Data.Common/DbDataReader.xml | View | Details | |
xml/System.Data/IDataReader.xml | ✅Succeeded | View |
xml/System.Data.Common/DbDataReader.xml
- Line 0, Column 0: [Warning-xref-not-found]
Cross reference not found: 'System.Data.DbDataReader.NextResult'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching in the Docs contributor and Admin Guide
- See the frequently asked questions
- Post your question in the Docs support channel
Docs Build status updates of commit 2bf3331: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@carlossanlop I think this is now ready for merging (am not sure if your process requires one of you to do it etc.). |
For context see dotnet/runtime#509, dotnet/runtime#41082