Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify when DbDataReader.GetSchemaTable returns null #4711

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

roji
Copy link
Member

@roji roji commented Aug 21, 2020

@opbld31
Copy link

opbld31 commented Aug 21, 2020

Docs Build status updates of commit ebb298f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbDataReader.xml ✅Succeeded View
xml/System.Data/IDataReader.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roji Left a suggestion for you to consider.

@carlossanlop
Copy link
Member

@TianqiZhang @joelmartinez do you know why the build passed for this change, considering the new text was outside xml elements?

@joelmartinez
Copy link
Contributor

@carlossanlop The pipeline (for the most part) really only processes the elements that it is familiar with ... so in case like this where it encounters free-floating text, it just skips over it since it doesn't know what to do with it.

@carlossanlop carlossanlop added the area-System.Data Data APIs (ADO.NET, XML, etc). label Feb 12, 2021
@carlossanlop
Copy link
Member

@roji can you please take a look again at this PR? I left some suggestions. There are also branch conflicts to resolve.

@opbld32
Copy link

opbld32 commented Feb 15, 2021

Docs Build status updates of commit 320fc02:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@roji
Copy link
Member Author

roji commented Feb 15, 2021

@carlossanlop sorry for leaving this PR for so long. I've merged the suggested fix and rebased on the latest master, resolving conflicts. There's a mergeability warning above which seems odd, though.

@opbld33
Copy link

opbld33 commented Feb 15, 2021

Docs Build status updates of commit 6ac08fe:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Data.Common/DbDataReader.xml ⚠️Warning View Details
xml/System.Data/IDataReader.xml ✅Succeeded View

xml/System.Data.Common/DbDataReader.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'System.Data.DbDataReader.NextResult'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Feb 15, 2021

Docs Build status updates of commit 2bf3331:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbDataReader.xml ✅Succeeded View
xml/System.Data/IDataReader.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@roji
Copy link
Member Author

roji commented Feb 17, 2021

@carlossanlop I think this is now ready for merging (am not sure if your process requires one of you to do it etc.).

@carlossanlop carlossanlop merged commit 8f576ec into master Feb 17, 2021
@carlossanlop carlossanlop deleted the GetSchemaTable branch February 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Data Data APIs (ADO.NET, XML, etc).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants