Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate DbDataReader.GetSchemaTable as nullable #41082

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

roji
Copy link
Member

@roji roji commented Aug 20, 2020

Reverts decision made in #509

/cc @ajcvickers @jeffhandley @stephentoub

@ghost
Copy link

ghost commented Aug 20, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I recommend waiting for at least one more approval.

@roji roji merged commit ab225ee into dotnet:master Aug 21, 2020
carlossanlop pushed a commit to carlossanlop/runtime that referenced this pull request Aug 28, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants