Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Alpine for .NET Samples #2167

Closed
richlander opened this issue Aug 12, 2020 · 4 comments · Fixed by #4171
Closed

Consider using Alpine for .NET Samples #2167

richlander opened this issue Aug 12, 2020 · 4 comments · Fixed by #4171
Assignees
Labels
area-samples enhancement needs-announcement An announcement is needed to discuss customer impact

Comments

@richlander
Copy link
Member

richlander commented Aug 12, 2020

Today, we use Debian for our samples. Our samples should put our best foot forward. I think using Alpine would be better since the samples would be much smaller. We'd have to figure out what to do for Linux ARM32 (we don't support Alpine for that configuration).

Experience today:

rich@thundera ~ % docker pull mcr.microsoft.com/dotnet/core/samples
Using default tag: latest
latest: Pulling from dotnet/core/samples
bf5952930446: Pull complete 
95f9f5484a21: Pull complete 
ebc43d54b0d9: Pull complete 
eb8b3fc30ae1: Pull complete 
de3474ac322e: Pull complete 
2befaca40243: Pull complete 
Digest: sha256:be09dbeae0cc5cbcd069d391399280eb8a3c3501cc021994e0ae353140dba2a8
Status: Downloaded newer image for mcr.microsoft.com/dotnet/core/samples:latest
mcr.microsoft.com/dotnet/core/samples:latest
rich@thundera ~ % docker images | grep mcr.microsoft.com/dotnet/core/samples
mcr.microsoft.com/dotnet/core/samples           latest                    203ee9fd2283        23 hours ago        190MB
rich@thundera ~ % docker images | grep 3.1                                    
mcr.microsoft.com/dotnet/core/runtime           3.1-alpine                b30a31240b43        5 hours ago         87.2MB
mcr.microsoft.com/dotnet/core/runtime           3.1                       c6f90064476b        24 hours ago        190MB
@MichaelSimons
Copy link
Member

We have two options for ARM32

  1. Don't publish ARM32 images in the samples repo.
  2. Build the ARM32 images based on a different distro (e.g. Debian) than the AMD64 and ARM64 images.

After discussing this we believe option 2 is the way to go.

@MichaelSimons
Copy link
Member

This change should be made when 5.0 is released. This is when the samples repo would transition from dotnet/core/samples to dotnet/samples.

@richlander
Copy link
Member Author

This issue is significantly related to #2182. They make sense to do together, or not at all.

@mthalman mthalman moved this to Backlog in .NET Docker Dec 1, 2021
@mthalman mthalman moved this from Backlog to On Deck in .NET Docker Oct 5, 2022
@mthalman
Copy link
Member

mthalman commented Oct 5, 2022

We'll first update the Alpine sample Dockerfiles to have an architecture-agnostic version of alpine-slim. That will serve as the basis for being able to publish the sample images. That means we won't use https://github.com/dotnet/dotnet-docker/blob/main/samples/aspnetapp/Dockerfile as the Dockerfile for building the images anymore.

@mthalman mthalman moved this from On Deck to In Progress in .NET Docker Oct 27, 2022
@mthalman mthalman added the needs-announcement An announcement is needed to discuss customer impact label Oct 27, 2022
@mthalman mthalman moved this from In Progress to Rollout in .NET Docker Oct 31, 2022
@mthalman mthalman closed this as completed Nov 9, 2022
Repository owner moved this from Rollout to Done in .NET Docker Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-samples enhancement needs-announcement An announcement is needed to discuss customer impact
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants