-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples to Alpine #4171
Update samples to Alpine #4171
Conversation
…otnet#4142) Update common Docker engineering infrastructure with latest
Because the tag names have changed, you'll also need to update this file to reference those new names: https://github.com/dotnet/dotnet-docker/blob/main/eng/mcr-tags-metadata-templates/samples-tags.yml. After updating that file, run |
FROM mcr.microsoft.com/dotnet/runtime-deps:7.0-alpine | ||
WORKDIR /app | ||
COPY --from=build /app . | ||
ENTRYPOINT ["./aspnetapp"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a newline at the end of the file. Applies to the other Dockerfile too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Done |
…LACEHOLDER> (dotnet#4143)" This reverts commit f0c9041.
FYI: I rebased this to nightly so we can get it merged there first. Then we'll merge it to main and get the new images published as part of the November release. |
I'm investigating an issue with the tests where they're not testing what we expect to be tested. This was apparently an issue prior to these changes but I just discovered it today. |
I have fixed the tests locally but that's uncovered a product issue which I've logged at dotnet/sdk#28809. |
Looks like this won't be fixed in GA. Our choices:
|
We should pick the option 2 as the goal is to have reduced size samples (using arch specific Dockerfiles) for better customer experience. But I am not sure on the benefit of deleting and adding the multi-arch file later. |
Option 1 gives us the reduced size as well, just a month later.
The multi-arch file is the canonical and more maintainable solution that we would want to guide customers to use. |
I am in favor of #2. There will be marketing buzz at 7.0.0 GA that we should take advantage of by making our published samples quicker to pull therefore leaving a more favorable impression. |
(cherry picked from commit fb07c27)
(cherry picked from commit fb07c27)
Fixes #2167