-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port enable Alpine ARM support (#41982) #42963
Conversation
This change ports to release/5.0 enabling Alpine ARM support in the lab build scripts packages and RID graph. It enables CI and official builds.
Tagging subscribers to this area: @ViktorHofer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. We should be able to take this as tell a tell mode change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding @mmitche to double check that we are not overlooking anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoyosjs ah, right, thank you for reminding me that. I'll add that commit to this PR. |
The fix for these builds was merged 3 hours ago into release/5.0. |
Description
This change back ports enabling Alpine ARM support
in the lab build scripts, packages and RID graph to release/5.0.
It enables CI and official builds.
There is no code change. We only had packages for
linux_musl_arm64 although support for building runtime
for MUSL ARM was present for as long as the arm64 one.
According to @richlander , this would also solve
dotnet/dotnet-docker#2167
Customer impact
Customers are able to target linux_musl_arm. There was a long standing issue
#2021 to enable this.
Regression
No
Testing
CoreCLR and libraries tests in the CI.
Risk
Low