Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port enable Alpine ARM support (#41982) #42963

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Oct 1, 2020

Description

This change back ports enabling Alpine ARM support
in the lab build scripts, packages and RID graph to release/5.0.
It enables CI and official builds.

There is no code change. We only had packages for
linux_musl_arm64 although support for building runtime
for MUSL ARM was present for as long as the arm64 one.

According to @richlander , this would also solve
dotnet/dotnet-docker#2167

Customer impact

Customers are able to target linux_musl_arm. There was a long standing issue
#2021 to enable this.

Regression

No

Testing

CoreCLR and libraries tests in the CI.

Risk

Low

This change ports to release/5.0 enabling Alpine ARM support
in the lab build scripts packages and RID graph. It enables
CI and official builds.
@janvorli janvorli added Servicing-consider Issue for next servicing release review area-Infrastructure labels Oct 1, 2020
@janvorli janvorli added this to the 5.0.0 milestone Oct 1, 2020
@janvorli janvorli requested review from ericstj and safern October 1, 2020 19:35
@janvorli janvorli self-assigned this Oct 1, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We should be able to take this as tell a tell mode change.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffschwMSFT
Copy link
Member

Adding @mmitche to double check that we are not overlooking anything

@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Oct 1, 2020
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janvorli you also need 8fc68f6, otherwise internal builds will break when trying to build the Cross DAC packages.

@janvorli
Copy link
Member Author

janvorli commented Oct 5, 2020

@hoyosjs ah, right, thank you for reminding me that. I'll add that commit to this PR.

@janvorli janvorli closed this Oct 6, 2020
@janvorli janvorli reopened this Oct 6, 2020
@safern
Copy link
Member

safern commented Oct 6, 2020

The fix for these builds was merged 3 hours ago into release/5.0.

@safern safern closed this Oct 6, 2020
@safern safern reopened this Oct 6, 2020
@janvorli janvorli closed this Oct 7, 2020
@janvorli janvorli reopened this Oct 7, 2020
@janvorli
Copy link
Member Author

janvorli commented Oct 8, 2020

The failures in the CI are #41494 and #43166, unrelated to the changes.

@janvorli janvorli merged commit d414588 into dotnet:release/5.0 Oct 8, 2020
@janvorli janvorli deleted the port-enable-arm-musl branch October 8, 2020 13:15
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants