Static analysis: use char instead of string literals

Part of #26805
dotnet · Dec 6, 2021 · 2a3a576 · 2a3a576
1 parent 57d1ec9
commit 2a3a576
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 17 deletions.
diff --git a/src/EFCore.Design/Design/Internal/CSharpHelper.cs b/src/EFCore.Design/Design/Internal/CSharpHelper.cs
@@ -428,9 +428,9 @@ private static string EnsureDecimalPlaces(double number)
             return $"double.{nameof(double.PositiveInfinity)}";
         }
 
-        return !literal.Contains("E")
-            && !literal.Contains("e")
-            && !literal.Contains(".")
+        return !literal.Contains('E')
+            && !literal.Contains('e')
+            && !literal.Contains('.')
                 ? literal + ".0"
                 : literal;
     }

diff --git a/src/EFCore.Design/Migrations/Design/CSharpSnapshotGenerator.cs b/src/EFCore.Design/Migrations/Design/CSharpSnapshotGenerator.cs
@@ -554,7 +554,7 @@ protected virtual void GenerateKey(
             .Append(entityTypeBuilderName)
             .Append(primary ? ".HasKey(" : ".HasAlternateKey(")
             .Append(string.Join(", ", key.Properties.Select(p => Code.Literal(p.Name))))
-            .Append(")")
+            .Append(')')
             .ToString();
 
         stringBuilder
@@ -990,7 +990,7 @@ protected virtual void GenerateForeignKey(
             }
         }
 
-        foreignKeyBuilderNameStringBuilder.Append(")");
+        foreignKeyBuilderNameStringBuilder.Append(')');
 
         var foreignKeyBuilderName = foreignKeyBuilderNameStringBuilder.ToString();
 

diff --git a/src/EFCore.Relational/Storage/DoubleTypeMapping.cs b/src/EFCore.Relational/Storage/DoubleTypeMapping.cs
@@ -62,9 +62,9 @@ protected override string GenerateNonNullSqlLiteral(object value)
         var doubleValue = Convert.ToDouble(value);
         var literal = doubleValue.ToString("G17", CultureInfo.InvariantCulture);
 
-        return !literal.Contains("E")
-            && !literal.Contains("e")
-            && !literal.Contains(".")
+        return !literal.Contains('E')
+            && !literal.Contains('e')
+            && !literal.Contains('.')
             && !double.IsNaN(doubleValue)
             && !double.IsInfinity(doubleValue)
                 ? literal + ".0"

diff --git a/src/EFCore.Relational/Update/UpdateSqlGenerator.cs b/src/EFCore.Relational/Update/UpdateSqlGenerator.cs
@@ -254,7 +254,7 @@ protected virtual void AppendInsertCommandHeader(
                     operations,
                     SqlGenerationHelper,
                     (sb, o, helper) => helper.DelimitIdentifier(sb, o.ColumnName))
-                .Append(")");
+                .Append(')');
         }
     }
 

diff --git a/src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs b/src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs
@@ -2581,7 +2581,7 @@ void EnablePeriod(string table, string? schema, string periodStartColumnName, st
                 .Append(Dependencies.SqlGenerationHelper.DelimitIdentifier(periodStartColumnName))
                 .Append(", ")
                 .Append(Dependencies.SqlGenerationHelper.DelimitIdentifier(periodEndColumnName))
-                .Append(")")
+                .Append(')')
                 .ToString();
 
             if (options.HasFlag(MigrationsSqlGenerationOptions.Idempotent))

diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerDoubleTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerDoubleTypeMapping.cs
@@ -65,8 +65,8 @@ protected override string GenerateNonNullSqlLiteral(object value)
         var literal = base.GenerateNonNullSqlLiteral(value);
 
         var doubleValue = Convert.ToDouble(value);
-        return !literal.Contains("E")
-            && !literal.Contains("e")
+        return !literal.Contains('E')
+            && !literal.Contains('e')
             && !double.IsNaN(doubleValue)
             && !double.IsInfinity(doubleValue)
                 ? literal + "E0"

diff --git a/src/EFCore.SqlServer/Storage/Internal/SqlServerStringTypeMapping.cs b/src/EFCore.SqlServer/Storage/Internal/SqlServerStringTypeMapping.cs
@@ -294,7 +294,7 @@ void AddConcatOperatorIfNeeded()
                     builder.Append(" AS ");
                     if (IsUnicode)
                     {
-                        builder.Append("n");
+                        builder.Append('n');
                     }
 
                     builder.Append("varchar(max))");

diff --git a/src/EFCore.SqlServer/Update/Internal/SqlServerUpdateSqlGenerator.cs b/src/EFCore.SqlServer/Update/Internal/SqlServerUpdateSqlGenerator.cs
@@ -263,18 +263,18 @@ private void AppendMergeCommandHeader(
         }
 
         commandStringBuilder
-            .Append(")")
+            .Append(')')
             .AppendLine(" ON 1=0")
             .AppendLine("WHEN NOT MATCHED THEN");
 
         commandStringBuilder
             .Append("INSERT ")
-            .Append("(")
+            .Append('(')
             .AppendJoin(
                 writeOperations,
                 SqlGenerationHelper,
                 (sb, o, helper) => helper.DelimitIdentifier(sb, o.ColumnName))
-            .Append(")");
+            .Append(')');
 
         AppendValuesHeader(commandStringBuilder, writeOperations);
         commandStringBuilder

diff --git a/src/dotnet-ef/Exe.cs b/src/dotnet-ef/Exe.cs
@@ -93,7 +93,7 @@ private static string ToArguments(IReadOnlyList<string> args)
                             {
                                 if (pendingBackslashes == 1)
                                 {
-                                    builder.Append("\\");
+                                    builder.Append('\\');
                                 }
                                 else
                                 {
-Original file line number
+Diff line change
@@ Expand Up / @@ -93,7 +93,7 @@ private static string ToArguments(IReadOnlyList<string> args) @@
                                 {
                                     if (pendingBackslashes == 1)
                                     {
-                                        builder.Append("\\");
+                                        builder.Append('\\');
                                     }
                                     else
                                     {
@@ Expand Down @@