Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues raised by static analysis #26805

Closed
ajcvickers opened this issue Nov 23, 2021 · 0 comments
Closed

Fix issues raised by static analysis #26805

ajcvickers opened this issue Nov 23, 2021 · 0 comments
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
7.0.0

Comments

@ajcvickers
Copy link
Contributor

No description provided.

@ajcvickers ajcvickers self-assigned this Nov 23, 2021
@ajcvickers ajcvickers added this to the MQ milestone Nov 23, 2021
ajcvickers added a commit that referenced this issue Nov 23, 2021
@ajcvickers
Automatic refactorings based on static analysis of EFCore project
0b166bc 
Mostly completely automatic; a few manual tweaks.

Part of #26805
@ajcvickers ajcvickers mentioned this issue Nov 23, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 5, 2021
@ajcvickers
Automatic refactorings based on static analysis of EFCore project
3ad858b 
Mostly completely automatic; a few manual tweaks.

Part of #26805
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: remove trailing commas
0ae7d10 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: use char instead of string literals
2a3a576 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: use range indexer and index from end
151a221 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: using declarations and await using
aceeaf2 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: use range indexer and index from end
7d6a411 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: conditional cleanup
f474055 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 6, 2021
@ajcvickers
Static analysis: Use ??=
a8e362d 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 6, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: use null propagation
09c8f4a 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 7, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: inconsistent naming and namespaces
2813548 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 7, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: use null propagation
cd2a031 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: use null propagation
cf288c2 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: redundancies in symbol declarations
11e6441 
Part of #26805.
@ajcvickers ajcvickers mentioned this issue Dec 7, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: redundancies in symbol declarations
b7e7dc2 
Part of #26805.
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: spelling
e9f835b 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 7, 2021
@ajcvickers
Static analysis: miscellaneous "code quality"
2d276f8 
Part of #26805.

- Simplify LINQ Any to All
- Convert if to ||
- Make abstract class constructor protected
- Convert to const
- Join declaration and assignment
- Replace with simple assignment
- Simplify conditional ternary
- Merge Where into FirstOrDefault
- Use Ordinal comparison
@ajcvickers ajcvickers mentioned this issue Dec 7, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 8, 2021
@ajcvickers
Static analysis: remove redundant nullable warning suppression
1b07458 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 8, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 8, 2021
@ajcvickers
Static analysis: minor small changes
9c0ff2c 
Part of #26805

For example:
- Assignment is not used
- Redundant discard
- Redundant explicit size in array creation
- Convert field to local
- Redundant verbatim prefix
- Redundant lambda parens
@ajcvickers ajcvickers mentioned this issue Dec 8, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 8, 2021
@ajcvickers
Static analysis: make members static
ae6ba2a 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 8, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 9, 2021
@ajcvickers
Static analysis: minor small changes
9ab4cad 
Part of #26805

For example:
- Assignment is not used
- Redundant discard
- Redundant explicit size in array creation
- Convert field to local
- Redundant verbatim prefix
- Redundant lambda parens
ajcvickers added a commit that referenced this issue Dec 9, 2021
@ajcvickers
Static analysis: minor small changes
bbbd6f5 
Part of #26805

For example:
- Assignment is not used
- Redundant discard
- Redundant explicit size in array creation
- Convert field to local
- Redundant verbatim prefix
- Redundant lambda parens
ajcvickers added a commit that referenced this issue Dec 9, 2021
@ajcvickers
Static analysis: spelling
49e615e 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 11, 2021
@ajcvickers
Static analysis: inconsistent naming and namespaces
50ea89e 
Part of #26805
ajcvickers added a commit that referenced this issue Dec 11, 2021
@ajcvickers
Static analysis: deconstruction
ab4c39d 
Part of #26805
@ajcvickers ajcvickers mentioned this issue Dec 11, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 12, 2021
@ajcvickers
Static analysis: revert tail recursion unrolling
9731b2e 
Part of #26805.
@ajcvickers ajcvickers mentioned this issue Dec 12, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 12, 2021
@ajcvickers
Static analysis: protect against mutating fields in hash calculations
ed5ae5c 
Part of #26805.
ajcvickers added a commit that referenced this issue Dec 14, 2021
@ajcvickers
Static analysis: revert tail recursion unrolling
1d73e40 
Part of #26805.
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 14, 2021
@ajcvickers ajcvickers modified the milestones: MQ, 7.0.0 Dec 14, 2021
@ajcvickers ajcvickers mentioned this issue Dec 16, 2021
Merged
ajcvickers added a commit that referenced this issue Dec 16, 2021
@ajcvickers
Static analysis: protect against mutating fields in hash calculations
f706061 
Part of #26805.
ajcvickers added a commit that referenced this issue Dec 17, 2021
@ajcvickers
Static analysis: protect against mutating fields in hash calculations
e167674 
Part of #26805.
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-global closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@ajcvickers