Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: query filters should be properly composed on top of FromSql #16326

Closed
maumar opened this issue Jun 28, 2019 · 0 comments · Fixed by #17037
Closed

Query: query filters should be properly composed on top of FromSql #16326

maumar opened this issue Jun 28, 2019 · 0 comments · Fixed by #17037
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@maumar
Copy link
Contributor

maumar commented Jun 28, 2019

Currently query filters are applied directly after EntityQueryable, i.e. before FromSQL call - this is unexpected, as FromSQL should be composed directly on top of EntityQueryable.
Instead, nav rewrite should detect that EntityQueryable is part of FromSQL and apply the filter after the FromSQL call

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 1, 2019
@ajcvickers ajcvickers assigned maumar and smitpatel and unassigned maumar Jul 1, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
smitpatel added a commit that referenced this issue Aug 7, 2019
This makes look up for EntityQueryable in query tree bit more complex but it adds support for providers to add custom EntityQueryable to carry more metadata as needs to and allow rest of the pipeline to be transparent about it.
Current FromSql has be to converted during compilation phase since, we want to parameterize the arguments array in the methodCall.
If there is nothing to parameterize then providers can directly create custom Queryable.

Resolves #16326
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 7, 2019
smitpatel added a commit that referenced this issue Aug 7, 2019
This makes look up for EntityQueryable in query tree bit more complex but it adds support for providers to add custom EntityQueryable to carry more metadata as needs to and allow rest of the pipeline to be transparent about it.
Current FromSql has be to converted during compilation phase since, we want to parameterize the arguments array in the methodCall.
If there is nothing to parameterize then providers can directly create custom Queryable.

Resolves #16326
smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 9, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
3 participants