Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Cleanup pattern matching to FromSql method in Core #17036

Closed
smitpatel opened this issue Aug 8, 2019 · 0 comments
Closed

Query: Cleanup pattern matching to FromSql method in Core #17036

smitpatel opened this issue Aug 8, 2019 · 0 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@smitpatel
Copy link
Member

smitpatel commented Aug 8, 2019

Issues:
Our query roots are entityQueryables in expression tree that is how we identify starting entityType during navigation expansion.

  • FromSql is also query root but relational method so core does not know about it. So query filters are supposed to be applied after FromSql method but does not happen.
    Few possible solutions:
  • Make FromSql a query root in the tree by introducing FromSqlEntityQueryable
    • FromSql method has parameters which needs to be funcletized. If FromSqlEntityQueryable is injected when the method is called then funcletizer needs to know about it and requires relational specific version.
    • If we inject FromSqlEntityQueryable after funcletizer part then FromSql in defining query wouldn't be changed. (The injector would be relational specific and navigation expansion cannot run a relational visitor).
  • Relational specific nav expansion which is only for to inject query root for FromSql method. This requires us to expose a lot of private code in nav expansion publicly.

For now, it is pattern matching on method in core level (since we cannot use actual MethodInfo). Given it is our own method, chances of it being broken is very low.

smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 8, 2019
smitpatel added a commit that referenced this issue Aug 9, 2019
@ajcvickers ajcvickers modified the milestone: Backlog Aug 12, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Development

No branches or pull requests

2 participants