Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AlterTableOperation doesn't have a full OldTable #16798

Closed
roji opened this issue Jul 28, 2019 · 0 comments · Fixed by #16981
Closed

AlterTableOperation doesn't have a full OldTable #16798

roji opened this issue Jul 28, 2019 · 0 comments · Fixed by #16981
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jul 28, 2019

While AlterColumnOperation has an OldColumn of type ColumnOperation, AlterTableOperation's OldTable property has type Annotatable. This only allows comparing annotations with their previous values and not relational, non-annotation values.

In particular this means we can't access the old comment on a table, to avoid generating the SQL for it every time the table is altered.
@roji roji mentioned this issue Jul 28, 2019
Closed
@ajcvickers ajcvickers added this to the Backlog milestone Jul 29, 2019
@roji roji mentioned this issue Jul 29, 2019
Closed
roji added a commit that referenced this issue Aug 6, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
d51a081 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
@roji roji mentioned this issue Aug 6, 2019
Merged
@roji roji self-assigned this Aug 6, 2019
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 6, 2019
@roji roji modified the milestones: Backlog, 3.0.0 Aug 6, 2019
roji added a commit that referenced this issue Aug 6, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
0b8cf69 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
fada576 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
f532505 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
3148cd0 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
@roji
Full OldTable on AlterTableOperation, further comment support
841963d 
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Full OldTable on AlterTableOperation, further comment support dotnet/efcore
2 participants
@ajcvickers @roji