Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup or back-out support for column/table comments #16819

Closed
ajcvickers opened this issue Jul 29, 2019 · 6 comments · Fixed by #16981
Closed

Cleanup or back-out support for column/table comments #16819

ajcvickers opened this issue Jul 29, 2019 · 6 comments · Fixed by #16981
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ajcvickers
Copy link
Member

Several issues with the implementation have been found--see #16800 #16799 #16808

Given where we are in the 3.0 schedule, we may need to back this out since this is not a priority feature.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jul 29, 2019
@bricelam
Copy link
Contributor

bricelam commented Jul 29, 2019

TODO

  • Remove MigrationsSqlGenerator.GenerateComment() (let providers handle comments however is best for them)
  • Test model differ with comments more
  • Update AlterTableOperation.OldTable to return TableOperation (mirroring ColumnOperation)

@bricelam bricelam assigned roji and unassigned bricelam Jul 29, 2019
@roji
Copy link
Member

roji commented Jul 29, 2019

Cleaned up the implementation, fixing #16800, #16794.

We have #16798 for tracking AlterTableOperation.OldTable.

@ErikEJ
Copy link
Contributor

ErikEJ commented Jul 30, 2019

How about the reverse engineering part?

@roji
Copy link
Member

roji commented Jul 30, 2019

@ErikEJ for now I think support can stay in, including the reverse engineering - the important issues have been fixed AFAIK, it's mostly a matter of better table alteration with AlterTableOperation.OldTable. So I wouldn't worry about it..

@bricelam
Copy link
Contributor

@ErikEJ Your RevEng changes looked great to me, and Andriy did a through review of the metadata changes. Somehow, I failed to properly review the Migrations changes. (Too heads-down on EF6)

@smitpatel
Copy link
Contributor

Missing labels

roji added a commit that referenced this issue Aug 6, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 6, 2019
roji added a commit that referenced this issue Aug 6, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
roji added a commit that referenced this issue Aug 9, 2019
Changed AlterTableOperation.OldTable from Annotatable to TableOperation,
and did various fixes throughout to support comment alteration on tables.

Some comment fixes and refactoring.

Fixes #16819
Fixes #16798
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants