Refactor comment removal #16808
Closed
Refactor comment removal #16808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
suggested changes
Jul 29, 2019
| @@ -1648,14 +1648,16 @@ protected virtual IUpdateSqlGenerator SqlGenerator | |||
| /// <param name="model"> The target model which may be <c>null</c> if the operations exist without a model. </param> | |||
| /// <param name="builder"> The command builder to use to build the commands. </param> | |||
| /// <param name="comment"> The comment to be applied. </param> | |||
| /// <param name="oldComment"> The previous comment. </param> | |||
| /// <param name="schema"> The schema of the table. </param> | |||
| /// <param name="table"> The name of the table. </param> | |||
| /// <param name="columnName"> The column name if comment is being applied to a column. </param> | |||
| protected virtual void GenerateComment( | |||
There was a problem hiding this comment.
Should we even have this template method? It seems to bring with it a lot of SQL Server-specific assumptions.
There was a problem hiding this comment.
I'm honestly not convinced. I already started a wider refactor (and then stopped), where we had separate methods for column, table (and possibly also index). Anyway, take a look at the whole thing and let's see where we go from there.
|
Will resubmit a more complete refactor/fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16799