Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat_Include_collection_ignored throws #17245

Closed
ajcvickers opened this issue Aug 18, 2019 · 1 comment
Closed

Concat_Include_collection_ignored throws #17245

ajcvickers opened this issue Aug 18, 2019 · 1 comment
Assignees
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ajcvickers
Copy link
Member

Microsoft.EntityFrameworkCore.Query.QueryLoggingSqlServerTest.Concat_Include_collection_ignored

Assert.Contains() Failure
Not found: The Include operation for navigation '[o].OrderDetails' is unnecessary and was ignored because the navigation is not reachable in the final query results. See https://go.microsoft.com/fwlink/?linkid=850303 for more information.
In value:  SelectListIterator<ValueTuple<LogLevel, EventId, String, Object, Exception>, String> ["(queryContext) => new QueryingEnumerable<Order>(\r"..., "Creating DbCommand for 'ExecuteReader'.", "Created DbCommand for 'ExecuteReader' (0ms).", "A data reader was disposed."]
   at Microsoft.EntityFrameworkCore.Query.QueryLoggingSqlServerTest.Concat_Include_collection_ignored() in C:\aspnet\EntityFrameworkCore\test\EFCore.SqlServer.FunctionalTests\Query\QueryLoggingSqlServerTest.cs:line 130
@smitpatel
Copy link
Contributor

We allow include after set operation.
#16065

@ajcvickers ajcvickers added this to the Backlog milestone Aug 19, 2019
@smitpatel smitpatel self-assigned this Aug 29, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 29, 2019
@smitpatel smitpatel modified the milestones: Backlog, 3.0.0 Aug 29, 2019
smitpatel added a commit that referenced this issue Aug 29, 2019
Filed #17498 to add logging
Resolves #17245
smitpatel added a commit that referenced this issue Aug 29, 2019
Filed #17498 to add logging
Resolves #17245
smitpatel added a commit that referenced this issue Aug 29, 2019
Filed #17498 to add logging
Resolves #17245
smitpatel added a commit that referenced this issue Sep 3, 2019
Filed #17498 to add logging
Resolves #17245
@bricelam bricelam modified the milestones: 3.0.0, 3.0.0-rc1 Sep 16, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-rc1, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants