Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete UseRowNumberPaging #18667

Closed
smitpatel opened this issue Oct 30, 2019 · 3 comments · Fixed by #18701
Closed

Obsolete UseRowNumberPaging #18667

smitpatel opened this issue Oct 30, 2019 · 3 comments · Fixed by #18701
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.1.0

Comments

@smitpatel
Copy link
Contributor

If we are not doing it for 3.1, it should at least be obsoleted so user gets error that it is not supported anymore.
@smitpatel
Copy link
Contributor Author

@aspnet/efteam - We should consider this for 3.1

@smitpatel smitpatel mentioned this issue Oct 30, 2019
Closed
@ajcvickers ajcvickers added this to the 3.1.0 milestone Oct 30, 2019
@ajcvickers ajcvickers self-assigned this Oct 30, 2019
@ajcvickers
Copy link
Member

Indeed. I'll do it if nobody gets to it first.

@ajcvickers
Copy link
Member

See also #18700

ajcvickers added a commit that referenced this issue Nov 1, 2019
@ajcvickers
Obsolete UseRowNumberForPaging
61adf13 
Fixes #18667
@ajcvickers ajcvickers mentioned this issue Nov 1, 2019
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 1, 2019
ajcvickers added a commit that referenced this issue Nov 1, 2019
@ajcvickers
Obsolete UseRowNumberForPaging
d0873f7 
Fixes #18667
ajcvickers added a commit that referenced this issue Nov 1, 2019
@ajcvickers
Obsolete UseRowNumberForPaging
8a636c0 
Fixes #18667
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview3, 3.1.0 Dec 2, 2019
@ismcagdas ismcagdas mentioned this issue Dec 12, 2019
Closed
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Obsolete UseRowNumberForPaging dotnet/efcore
2 participants
@ajcvickers @smitpatel