Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete UseRowNumberForPaging #18701

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Obsolete UseRowNumberForPaging #18701

merged 1 commit into from
Nov 1, 2019

Conversation

ajcvickers
Copy link
Member

Fixes #18667

@ajcvickers
Copy link
Member Author

/cc @Pilchie

@ajcvickers ajcvickers merged commit 8a636c0 into release/3.1 Nov 1, 2019
@ajcvickers ajcvickers deleted the LivingIn20081101 branch November 1, 2019 22:15
@ajcvickers ajcvickers mentioned this pull request Nov 7, 2019
Closed
WeihanLi
WeihanLi reviewed Nov 20, 2019
View reviewed changes
src/EFCore.SqlServer/Infrastructure/SqlServerDbContextOptionsBuilder.cs
@@ -35,6 +35,7 @@ public SqlServerDbContextOptionsBuilder([NotNull] DbContextOptionsBuilder option
/// <summary>
/// Use a ROW_NUMBER() in queries instead of OFFSET/FETCH. This method is backwards-compatible to SQL Server 2005.
/// </summary>
[Obsolete("Row-number paging is no longer supported. See https://ak.ms/AA6h122 for more information.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong link here, should be https://aka.ms/AA6h122

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeihanLi Thanks for pointing this out. See #19004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeihanLi WeihanLi WeihanLi left review comments

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@smitpatel smitpatel Awaiting requested review from smitpatel

@maumar maumar Awaiting requested review from maumar

@bricelam bricelam Awaiting requested review from bricelam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete UseRowNumberPaging
3 participants
@ajcvickers @AndriySvyryd @WeihanLi