Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various model building issues #22414

Open
3 of 6 tasks
AndriySvyryd opened this issue Sep 5, 2020 · 0 comments
Open
3 of 6 tasks

Various model building issues #22414

AndriySvyryd opened this issue Sep 5, 2020 · 0 comments
Assignees
@AndriySvyryd
Labels
area-model-building punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-bug
Milestone
Backlog

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Sep 5, 2020 •
edited
Loading

  • IConvention* extension methods that set annotations should return the value from the annotation that was set
  • FinalizeModel should not return null
  • Pass in principal type when attaching FK
  • Inverting identifying FK to derived moves the FK to base

    efcore/src/EFCore/Metadata/Internal/InternalForeignKeyBuilder.cs

    Line 1549 in baa864e

    dependentEntityType = dependentEntityType.LeastDerivedType(Metadata.PrincipalEntityType);
  • HasForeignKey sets FK properties after creating FK

    efcore/src/EFCore/Metadata/Internal/InternalEntityTypeBuilder.cs

    Line 2633 in baa864e

    var relationship = newRelationship.HasForeignKey(dependentProperties, configurationSource);
  • Add a public IConventionEntityType extension method GetTargetEntityTypeBuilder
@AndriySvyryd AndriySvyryd self-assigned this Sep 5, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Sep 8, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, Backlog Aug 19, 2021
@AndriySvyryd AndriySvyryd changed the title Various model building issues Various model building API issues Aug 19, 2021
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Oct 25, 2021
@AndriySvyryd AndriySvyryd mentioned this issue Jul 6, 2022
Open
4 tasks
@AndriySvyryd AndriySvyryd changed the title Various model building API issues Various model building issues Aug 9, 2022
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Add IConventionEntityTypeBuilder.GetTargetEntityTypeBuilder
9867d8c 
Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Add IConventionEntityTypeBuilder.GetTargetEntityTypeBuilder
e542e35 
Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414
@AndriySvyryd AndriySvyryd mentioned this issue Aug 9, 2022
Merged
AndriySvyryd added a commit that referenced this issue Aug 9, 2022
@AndriySvyryd
Add IConventionEntityTypeBuilder.GetTargetEntityTypeBuilder
f93f927 
Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414
AndriySvyryd added a commit that referenced this issue Aug 10, 2022
@AndriySvyryd
Add IConventionEntityTypeBuilder.GetTargetEntityTypeBuilder
1e122ac 
Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414
@ajcvickers ajcvickers added the punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. label Sep 13, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriySvyryd AndriySvyryd

Labels
area-model-building punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd