Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IConventionEntityTypeBuilder.GetTargetEntityTypeBuilder #28637

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

AndriySvyryd
Copy link
Member

Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414

@AndriySvyryd AndriySvyryd requested a review from a team August 9, 2022 19:52
Make all IConvention* extension methods that set annotations return the value from the annotation that was set

Part of #22414
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary break where the return type changes?

@AndriySvyryd
Copy link
Member Author

Binary break where the return type changes?

That's why I'm doing it before we ship public conventions

@AndriySvyryd AndriySvyryd merged commit 1e122ac into main Aug 10, 2022
@AndriySvyryd AndriySvyryd deleted the Issue22414 branch August 10, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants