Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevEng: Dedupe code in scaffolding code generator #25546

Closed
smitpatel opened this issue Aug 16, 2021 · 0 comments · Fixed by #28549
Closed

RevEng: Dedupe code in scaffolding code generator #25546

smitpatel opened this issue Aug 16, 2021 · 0 comments · Fixed by #28549
Assignees
@bricelam
Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
7.0.0

Comments

@smitpatel
Copy link
Contributor

See GenerateManyToMany method.

See #25544 (comment)

Main issue is that current implementation assumed that we won't have nesting in entity type fluent APIs (since we never detect owned entities or TPT) but the join entity is configured using nesting via UsingEntity API.
@smitpatel smitpatel mentioned this issue Aug 16, 2021
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Aug 17, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Jul 29, 2022
@bricelam
Scaffolding: Create default templates
b673c28 
This refactors our existing scaffolding code into T4 templates that we can both precompile to use as our default code generator and also ship somehow (probably `dotnet new`) as a starting point for users to start customizing.

Part of dotnet#4038, part of dotnet#14545, fixes dotnet#25473, resolves dotnet#25546, resolves dotnet#25547, fixes dotnet#27087, part of dotnet#27588, fixes dotnet#28187
@bricelam bricelam mentioned this issue Jul 29, 2022
Merged
@bricelam bricelam self-assigned this Jul 29, 2022
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 29, 2022
@bricelam bricelam modified the milestones: Backlog, 7.0.0 Jul 29, 2022
bricelam added a commit to bricelam/efcore that referenced this issue Aug 1, 2022
@bricelam
Scaffolding: Create default templates
987be97 
This refactors our existing scaffolding code into T4 templates that we can both precompile to use as our default code generator and also ship somehow (probably `dotnet new`) as a starting point for users to start customizing.

Part of dotnet#4038, part of dotnet#14545, fixes dotnet#25473, resolves dotnet#25546, resolves dotnet#25547, fixes dotnet#27087, part of dotnet#27588, fixes dotnet#28187
bricelam added a commit to bricelam/efcore that referenced this issue Aug 8, 2022
@bricelam
Scaffolding: Create default templates
f831c63 
This refactors our existing scaffolding code into T4 templates that we can both precompile to use as our default code generator and also ship somehow (probably `dotnet new`) as a starting point for users to start customizing.

Part of dotnet#4038, part of dotnet#14545, fixes dotnet#25473, resolves dotnet#25546, resolves dotnet#25547, fixes dotnet#27087, part of dotnet#27588, fixes dotnet#28187
@bricelam bricelam modified the milestones: 7.0.0, 7.0.0-rc1 Aug 10, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-scaffolding closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Scaffolding: Create default templates bricelam/efcore
3 participants
@bricelam @ajcvickers @smitpatel