Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Make ScalarSubqueryExpression fully immutable #26532

Closed
smitpatel opened this issue Nov 3, 2021 · 1 comment · Fixed by #27011
Closed

Query: Make ScalarSubqueryExpression fully immutable #26532

smitpatel opened this issue Nov 3, 2021 · 1 comment · Fixed by #27011
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone
7.0.0

Comments

@smitpatel
Copy link
Contributor

The subquery inside of it should be immutable object.
@smitpatel smitpatel self-assigned this Nov 3, 2021
This was referenced Nov 3, 2021
Closed
Closed
@smitpatel
Copy link
Contributor Author

Also ExistExpression. InExpression with subquery.

@ajcvickers ajcvickers added this to the 7.0.0 milestone Nov 5, 2021
smitpatel added a commit that referenced this issue Dec 15, 2021
@smitpatel
Query: Mark SelectExpression as immutable after projection has been a…
c7598b1 
…pplied

- Add an internal state to remember the mutability which is set to false after ApplyProjection is called.
- Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery
- Add debug check to verify that all SelectExpression are marked as immutable
- Clone mapped projection of SqlExpression kind before translating it further to avoid reference sharing with projection which may be applied at later stage

Resolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
Resolves #26104 - by cloning the projection before translating further. This issue may get resolved in other way after pending selector work if we reuse projections from subquery but regardless the change seems better to avoid reference sharing of SelectExpression objects
@smitpatel smitpatel mentioned this issue Dec 15, 2021
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 15, 2021
smitpatel added a commit that referenced this issue Dec 15, 2021
@smitpatel
Query: Mark SelectExpression as immutable after projection has been a…
7c9beee 
…pplied

- Add an internal state to remember the mutability which is set to false after ApplyProjection is called.
- Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery
- Add debug check to verify that all SelectExpression are marked as immutable
- Clone mapped projection of SqlExpression kind before translating it further to avoid reference sharing with projection which may be applied at later stage

Resolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
Resolves #26104 - by cloning the projection before translating further. This issue may get resolved in other way after pending selector work if we reuse projections from subquery but regardless the change seems better to avoid reference sharing of SelectExpression objects
smitpatel added a commit that referenced this issue Dec 15, 2021
@smitpatel
Query: Mark SelectExpression as immutable after projection has been a…
e4d4257 
…pplied

- Add an internal state to remember the mutability which is set to false after ApplyProjection is called.
- Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery
- Add debug check to verify that all SelectExpression are marked as immutable

Resolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
smitpatel added a commit that referenced this issue Jan 20, 2022
@smitpatel
Query: Mark SelectExpression as immutable after projection has been a…
f8a4bca 
…pplied

- Add an internal state to remember the mutability which is set to false after ApplyProjection is called.
- Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery
- Add debug check to verify that all SelectExpression are marked as immutable

Resolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
smitpatel added a commit that referenced this issue Jan 20, 2022
@smitpatel
Query: Mark SelectExpression as immutable after projection has been a…
70b0adf 
…pplied (#27011)

- Add an internal state to remember the mutability which is set to false after ApplyProjection is called.
- Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery
- Add debug check to verify that all SelectExpression are marked as immutable

Resolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Query: Mark SelectExpression as immutable after projection has been applied dotnet/efcore
2 participants
@ajcvickers @smitpatel