Query: Mark SelectExpression as immutable after projection has been applied #27011
Conversation
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
smitpatel
force-pushed
the
smit/clarity
branch
from
c7598b1 to
7c9beee
Compare
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
smitpatel
force-pushed
the
smit/clarity
branch
from
7c9beee to
e4d4257
Compare
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
…pplied - Add an internal state to remember the mutability which is set to false after ApplyProjection is called. - Add overload of ApplyProjection which ignores shaper to create an immutable select expression to be used as subquery - Add debug check to verify that all SelectExpression are marked as immutable Resolves #26532 - all those expressions have debug check in ctor Resolves #26167 - by having more accurate flag for immutability
smitpatel
force-pushed
the
smit/clarity
branch
from
e4d4257 to
f8a4bca
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Clone mapped projection of SqlExpression kind before translating it further to avoid reference sharing with projection which may be applied at later stageResolves #26532 - all those expressions have debug check in ctor
Resolves #26167 - by having more accurate flag for immutability
Resolves #26104 - by cloning the projection before translating further. This issue may get resolved in other way after pending selector work if we reuse projections from subquery but regardless the change seems better to avoid reference sharing of SelectExpression objects