Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling back a bulk insert command doesn't work #28712

Closed
roji opened this issue Aug 15, 2022 · 0 comments · Fixed by #28713
Closed

Rolling back a bulk insert command doesn't work #28712

roji opened this issue Aug 15, 2022 · 0 comments · Fixed by #28713
Assignees
@roji
Labels
area-save-changes area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Aug 15, 2022

When a command is added to a batch which goes over a limit (e.g. too many commands, too many parameters), we "roll it back", resetting the batch's state as if that command wasn't added. When adding a bulk-insert command for SQL Server, this isn't done properly: the command is removed from the SQL Server pending commands list, but the base rollback tasks are skipped. As a result, the batch state partially remains as if the command has been successfully added.
@roji roji added this to the 7.0.0 milestone Aug 15, 2022
@roji roji self-assigned this Aug 15, 2022
roji added a commit to roji/efcore that referenced this issue Aug 15, 2022
@roji
Fix bugs in SQL Server bulk insert management
98ee073 
Fixes dotnet#27840
Fixes dotnet#28712
@roji roji mentioned this issue Aug 15, 2022
Merged
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 15, 2022
roji added a commit to roji/efcore that referenced this issue Aug 15, 2022
@roji
Fix bugs in SQL Server bulk insert management
6488a72 
Fixes dotnet#27840
Fixes dotnet#28712
roji added a commit to roji/efcore that referenced this issue Aug 15, 2022
@roji
Fix bugs in SQL Server bulk insert management
b233f1e 
Fixes dotnet#27840
Fixes dotnet#28712
roji added a commit to roji/efcore that referenced this issue Aug 15, 2022
@roji
Fix bugs in SQL Server bulk insert management
094e63f 
Fixes dotnet#27840
Fixes dotnet#28712
@ghost ghost closed this as completed in #28713 Aug 15, 2022
ghost pushed a commit that referenced this issue Aug 15, 2022
@roji
Fix bugs in SQL Server bulk insert management (#28713)
42b093f 
Fixes #27840
Fixes #28712
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-rc1 Aug 16, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc1, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-save-changes area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix bugs in SQL Server bulk insert management roji/efcore
2 participants
@ajcvickers @roji