Fix bugs in SQL Server bulk insert management #28713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the parameter check, we previously added the parameters only when the pending bulk insert commands were applied; this is why they weren't being taken into account for the parameter limit check. The fix here is to move parameter adding to when the bulk insert command is added, just like any normal command; only the SQL addition is deferred.
Note that this won't support fancy bulk strategies, such as a single array parameter for multiple rows in PostgreSQL. But other things have to be done for that anyway, and this seems like an acceptable fix for now.
Fixes #27840
Fixes #28712