Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in SQL Server bulk insert management #28713

Merged
1 commit merged into from
Aug 15, 2022
Merged

Conversation

roji
Copy link
Member

@roji roji commented Aug 15, 2022

For the parameter check, we previously added the parameters only when the pending bulk insert commands were applied; this is why they weren't being taken into account for the parameter limit check. The fix here is to move parameter adding to when the bulk insert command is added, just like any normal command; only the SQL addition is deferred.

Note that this won't support fancy bulk strategies, such as a single array parameter for multiple rows in PostgreSQL. But other things have to be done for that anyway, and this seems like an acceptable fix for now.

Fixes #27840
Fixes #28712

@roji roji requested a review from AndriySvyryd August 15, 2022 01:21
@roji roji marked this pull request as draft August 15, 2022 01:23
@roji roji marked this pull request as ready for review August 15, 2022 02:43
);
}

return sqlLength < MaxScriptLength;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should log to Debug the reason why a batch is broken up, but this can be done later

Copy link
Member Author

@roji roji Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this can be done later

Like everything involving a new logging event, this now has a hard dependency on #28603 🤣

#28717

@ghost
Copy link

ghost commented Aug 15, 2022

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 15, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost
Copy link

ghost commented Aug 15, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 42b093f into dotnet:main Aug 15, 2022
@roji roji deleted the ParameterLimitCheck branch August 15, 2022 11:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants