Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove this method and let different instances of ColumnExpression exist #28838

Closed
smitpatel opened this issue Aug 22, 2022 · 0 comments · Fixed by #28888
Closed

Remove this method and let different instances of ColumnExpression exist #28838

smitpatel opened this issue Aug 22, 2022 · 0 comments · Fixed by #28888
Assignees
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone

Comments

@smitpatel
Copy link
Contributor

/// <summary>
/// Makes this JSON query expression nullable re-using existing nullable key properties
/// </summary>
/// <returns>A new expression which has <see cref="IsNullable" /> property set to true.</returns>
[EntityFrameworkInternal]
public virtual JsonQueryExpression MakeNullable(IReadOnlyDictionary<IProperty, ColumnExpression> nullableKeyPropertyMap)
=> Update(
JsonColumn.MakeNullable(),
nullableKeyPropertyMap,
JsonPath,
nullable: true);

@smitpatel smitpatel self-assigned this Aug 22, 2022
@ajcvickers ajcvickers added this to the 7.0.0 milestone Aug 24, 2022
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 25, 2022
smitpatel added a commit that referenced this issue Aug 25, 2022
smitpatel added a commit that referenced this issue Aug 25, 2022
smitpatel added a commit that referenced this issue Sep 8, 2022
smitpatel added a commit that referenced this issue Sep 8, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-rc2 Sep 9, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-rc2, 7.0.0 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants