Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Change JSONQuery.Path to be list of PathSegment #28888

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

smitpatel
Copy link
Contributor

Resolves #28838
Resolves #28836

@smitpatel smitpatel requested a review from a team August 25, 2022 22:40
@smitpatel
Copy link
Contributor Author

This could be easier to review https://github.com/dotnet/efcore/pull/28888/files?w=1

2 Files which majorly changed converted to file scoped namespace.

@smitpatel
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not very important, just for my understanding: when we add JSON array indexing support (#28648), we'd augment PathSegment to support an array index in addition to a string key, right? Would the array index be a SqlExpression (e.g. some column containing the index to go into)?

src/EFCore.Relational/Query/JsonQueryExpression.cs Outdated Show resolved Hide resolved
@smitpatel
Copy link
Contributor Author

Not very important, just for my understanding: when we add JSON array indexing support (#28648), we'd augment PathSegment to support an array index in addition to a string key, right? Would the array index be a SqlExpression (e.g. some column containing the index to go into)?

Yes. Exactly that is how we will add support.

@smitpatel smitpatel merged commit e11b7b8 into release/7.0 Sep 8, 2022
@smitpatel smitpatel deleted the smit/apichange branch September 8, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants