Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default implementation of IDatabaseModelFactory #3438

Closed
natemcmaster opened this issue Oct 15, 2015 · 7 comments
Closed

Create default implementation of IDatabaseModelFactory #3438

natemcmaster opened this issue Oct 15, 2015 · 7 comments
Assignees

Comments

@natemcmaster
Copy link
Contributor

It is maybe possible to provide a base implementation of IMetadataReader so that provider-writers only need to give us SQL queries to make reveng work. Use INFORMATION_SCHEMA

Related #1667

@rowanmiller
Copy link
Contributor

We should look at using EF when we do this

@natemcmaster natemcmaster changed the title Create default implementation of IMetadataReader Create default implementation of IDatabaseModelFactory Oct 23, 2015
@natemcmaster
Copy link
Contributor Author

@rowanmiller
Copy link
Contributor

As a workaround to #3943 you should be able to put these things in shadow state and then after you execute the query run some additional logic to copy the values out of the change tracker into the annotations.

@divega
Copy link
Contributor

divega commented Dec 2, 2015

@natemcmaster is the materialization hook you mention in #3943 a need to have in the sense that you cannot resolve this issue (#3438) without it? I would like to understand if it can be worked around.

@natemcmaster
Copy link
Contributor Author

Listing the limitations above was more about minimizing workarounds and driving useful features in EF. They can all be worked around.

@divega #3943 can be a "nice to have" since we don't plan to support multiple rows => one entity (#3945).

copy the values out of the change tracker

@rowanmiller this was my original approach. Of course this means I have to use the change tracker ( see #2282 (comment))

@rowanmiller
Copy link
Contributor

@natemcmaster we agreed not to use EF for loading metadata, but is the more general scenario covered by this issue (providers just needing to provide SQL) done?

@natemcmaster
Copy link
Contributor Author

This general scenario is not done. We still only have a Sql Server and SQLite implementation with no shared implementation.

@rowanmiller rowanmiller modified the milestone: 7.0.0 Dec 15, 2015
@rowanmiller rowanmiller removed this from the 1.0.0 milestone May 4, 2016
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants