Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Optimize QueryOptimizer #7831

Closed
smitpatel opened this issue Mar 10, 2017 · 2 comments
Closed

Query: Optimize QueryOptimizer #7831

smitpatel opened this issue Mar 10, 2017 · 2 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. punted-for-2.0 type-cleanup

Comments

@smitpatel
Copy link
Contributor

smitpatel commented Mar 10, 2017 •
edited
Loading

QueryModelOptimizer derives from SubQueryFromClauseFlattener class which in turn derives from QueryModelVisitorBase.

  • QMVBase class does not visit, QueryModels recursively, hence subQMs inside SelectClause etc are not visited by optimizer. We need ExpressionVisitor to apply QueryModelOptimizer recursively.
  • Expand logic of lifting of subquery.
  • Verify if we need to derive from SubQueryFromClauseFlattener, its code structure has a specific format which we can get rid of.
@anpete anpete mentioned this issue Mar 10, 2017
Closed
12 tasks
@ajcvickers ajcvickers added this to the 2.0.0 milestone Mar 10, 2017
@smitpatel smitpatel mentioned this issue Mar 10, 2017
Merged
@smitpatel smitpatel reopened this Mar 11, 2017
@smitpatel
Copy link
Contributor Author

Reopening since we can still get rid of SubQueryFromClauseFlattener

@tuespetre tuespetre mentioned this issue Mar 11, 2017
Closed
@smitpatel smitpatel changed the title QueryOptimizer does not go through query model recursively Optimize QueryOptimizer Mar 21, 2017
@maumar maumar removed this from the 2.0.0 milestone Apr 13, 2017
@ajcvickers ajcvickers added this to the Backlog milestone Apr 17, 2017
@smitpatel smitpatel removed their assignment Sep 13, 2017
@ajcvickers ajcvickers changed the title Optimize QueryOptimizer Query: Optimize QueryOptimizer May 16, 2018
@AndriySvyryd
Copy link
Member

@smitpatel Not needed?

@smitpatel smitpatel removed this from the Backlog milestone Aug 23, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. punted-for-2.0 type-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajcvickers @smitpatel @maumar @AndriySvyryd