Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes SelectExpressions are pushed down unnecessarily #7766

Closed
tuespetre opened this issue Mar 2, 2017 · 3 comments
Closed

Sometimes SelectExpressions are pushed down unnecessarily #7766

tuespetre opened this issue Mar 2, 2017 · 3 comments
Labels
closed-duplicate type-bug

Comments

@tuespetre
Copy link
Contributor

There are many cases where, for one reason or another, LiftSubQuery will push a SelectExpression down into a subquery even though it is not required.

Some examples:

  • It's being pushed down in the MainFromClause even though there are no JoinClauses, GroupJoinClauses, or AdditionalFromClauses
  • It's being pushed down in a JoinClause, a GroupJoinClause, or an AdditionalFromClause even though the query will not be able to be flattened
@tuespetre tuespetre mentioned this issue Mar 2, 2017
Closed
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 3, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
134f768 
Fixes dotnet#7766
@tuespetre tuespetre mentioned this issue Mar 3, 2017
Closed
@rowanmiller rowanmiller added this to the 2.0.0 milestone Mar 3, 2017
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 3, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
2253b57 
Fixes dotnet#7766
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 3, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
bb73b98 
Fixes dotnet#7766
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 7, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
6b405aa 
Fixes dotnet#7766
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 8, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
d7f5c64 
Fixes dotnet#7766
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 8, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
a882135 
Fixes dotnet#7766
tuespetre added a commit to tuespetre/EntityFramework that referenced this issue Mar 8, 2017
@tuespetre
Query: Relational: only push down subqueries when needed.
d5174d4 
Fixes dotnet#7766
@tuespetre
Copy link
Contributor Author

This was largely resolved by #7843 and will be handled when #7831 is addressed (the third point about inheriting from SubQueryFromClauseFlattenrr, to be specific)

cc @smitpatel

@divega
Copy link
Contributor

divega commented May 8, 2017

@maumar @smitpatel @anpete should this issue be marked as closed-fixed as per the comment above? Or is it a duplicate?

@smitpatel
Copy link
Contributor

dupe of #8094

@divega divega removed this from the 2.0.0-preview1 milestone May 8, 2017
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-duplicate type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@divega @ajcvickers @smitpatel @maumar @rowanmiller @tuespetre