Query: Lift Subqueries when outer QM's select can be pushed down into… #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
reviewed
Mar 10, 2017
| protected override Expression VisitSubQuery(SubQueryExpression expression) | ||
| { | ||
| TransformingVisitor.VisitQueryModel(expression.QueryModel); | ||
| return expression; |
There was a problem hiding this comment.
nit: add newline before return
There was a problem hiding this comment.
thanks for reminding, it should be changed to base visitor actually.
There was a problem hiding this comment.
And base returns expression only. 
There was a problem hiding this comment.
@maumar - Decide what you want? return Expression or call base? 😛
There was a problem hiding this comment.
call base is "more correct" ;)
smitpatel
force-pushed
the
queryoptimizer
branch
from
77984e0 to
2562839
Compare
maumar
approved these changes
Mar 10, 2017
smitpatel
force-pushed
the
queryoptimizer
branch
from
2562839 to
6bb74c7
Compare
smitpatel
force-pushed
the
queryoptimizer
branch
from
6bb74c7 to
9d27856
Compare
|
@maumar - Updated. |
smitpatel
force-pushed
the
queryoptimizer
branch
3 times, most recently
from
01208a8 to
8b2f7cd
Compare
… subqueryQM Apply QueryOptimizer recursively on all QueryModels Introduce SubQueryExpressionVisitor<IQueryModelVisitor> to apply QMV's recursively.
smitpatel
force-pushed
the
queryoptimizer
branch
from
8b2f7cd to
b883abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… subqueryQM
Apply QueryOptimizer recursively on all QueryModels
Introduce SubQueryExpressionVisitor to apply QMV's recursively. @maumar
Partially fix #7831