Query: Improve the logic of null expansion in join conditions with an… #7826
Conversation
smitpatel
force-pushed
the
testing
branch
2 times, most recently
from
58de9f1 to
60bba22
Compare
|
Updated. |
| && expressionType == ExpressionType.Equal) | ||
| { | ||
| var translatedExpression = TransformNullComparison(leftExpressions[0], rightExpressions[0], binaryExpression.NodeType) | ||
| ?? Expression.MakeBinary(expressionType, leftExpressions[0], rightExpressions[0]); |
There was a problem hiding this comment.
use ExpressionType.Equal rather than expressionType here, just so its more clear
| { | ||
| var translatedExpression = TransformNullComparison(leftExpressions[0], rightExpressions[0], binaryExpression.NodeType) | ||
| ?? Expression.MakeBinary(expressionType, leftExpressions[0], rightExpressions[0]); | ||
| return Expression.AndAlso(translatedExpression, Expression.Constant(true, translatedExpression.Type)); |
There was a problem hiding this comment.
Expression.Constant(true), since translatedExpression is guaranteed to be bool
There was a problem hiding this comment.
I actually forgot to submit updated. Will fix in future PR.
There was a problem hiding this comment.
Is TranslatedExpression is guaranteed to return bool type?
There was a problem hiding this comment.
It should be but it's not that clear. I guess it is safer to leave it as is after all
There was a problem hiding this comment.
I concluded this way:
TransformNullComparison returns either IsNullExpression or Not(IsNullExpression).
IsNullExpression as type hardcoded to bool. Not expression takes type from the inner expression so it have to bool only in this case.
…onymous types
@maumar @anpete
Due to the way LINQ processes
equalswith normal properties comparison & anonymous type comparison.