Fix DiagnosticListener memory leak #16046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IsConfigured is called, it applies all services. This caused a DiagnosticListener to get instantiated on each DbContext instantiation, and since it wasn't disposed it caused a leak. Fixes #15173
Closed
ajcvickers
approved these changes
Jun 12, 2019
|
@roji Can you please prepare a PR for the 2.2 branch, but don't merge anything. @dougbu @JunTaoLuo @natemcmaster Just a heads-up that we're going to be bring a 2.2 patch for this to shiproom on Tuesday. /cc @divega @Pilchie FYI: This is a pretty bad memory leak; we need to patch. Also, leak does not happen on 2.1, so no need to consider patching there. |
ghost
deleted the
|
@ajcvickers done, PR for 2.2: #16047 |
|
@roji Would removing the call to IsConfigured work around / get rid of the leak? |
|
@ErikEJ yes, that is the current workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IsConfigured is called, it applies all services. This caused a DiagnosticListener to get instantiated on each DbContext instantiation, and since it wasn't disposed it caused a leak.
Fixes #15173